Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix check taskItem #2376

Closed
wants to merge 1 commit into from
Closed

Conversation

Morgbn
Copy link

@Morgbn Morgbn commented Jan 11, 2022

It seems that the getPos function must be called immediately.
Resolves #2372

@netlify
Copy link

netlify bot commented Jan 11, 2022

✔️ Deploy Preview for tiptap-embed ready!

🔨 Explore the source changes: 098a3fc

🔍 Inspect the deploy log: https://app.netlify.com/sites/tiptap-embed/deploys/61dd5433d7340d00070488c1

😎 Browse the preview: https://deploy-preview-2376--tiptap-embed.netlify.app

@philippkuehn
Copy link
Contributor

This leads to errors, because the position must be calculated in the click event, as the position may have changed in the meantime.

@Morgbn
Copy link
Author

Morgbn commented Jan 11, 2022

Okay sorry, it's the first time I dive in the tiptap code (by the way, an amazing library), I don't find another way to prevent getPos() to return undefined. And I don't even know why getPos return undefined in my Chrome browser (from tiptap.dev example or from my code or from demos folder build in local) and not in private nav or Firefox. Sorry for the time taken..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when check taskItem
2 participants